apex icon indicating copy to clipboard operation
apex copied to clipboard

Add custom build backend to support build args

Open janEbert opened this issue 2 years ago • 3 comments

This implements a custom build backend, inspired by the solution used by Pillow.

--build-options aren't actually passed to the build_wheel command for reasons unknown to me. So this patches setuptools.build_meta to take the flags manually.

The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the build_meta:__legacy__ backend.

This actually fixes what #1690 meant to do and seems fully backward-compatible.

janEbert avatar Jul 06 '23 08:07 janEbert

Ref #1679.

janEbert avatar Jul 06 '23 08:07 janEbert

I and others are still facing issues that this PR, coupled with https://github.com/NVIDIA/apex/pull/1680, would resolve. Is there anything I can do (testing, fix any remaining hangups, etc) to get this merged into upstream?

Quentin-Anthony avatar Oct 27 '23 22:10 Quentin-Anthony

@crcrpar - thoughts on merging this PR?

loadams avatar Oct 30 '23 15:10 loadams