apex icon indicating copy to clipboard operation
apex copied to clipboard

.cu files should not include torch/extension.h

Open lostmsu opened this issue 1 year ago • 4 comments

See https://github.com/facebookresearch/pytorch3d/issues/1127#issuecomment-1071206320

This causes nvcc trying to deal with pybind, which fails with

error: too few arguments for template template parameter "Tuple"

lostmsu avatar Aug 14 '22 03:08 lostmsu

I tried adding libraries=['cublas'] argument, but it did not seem to affect linker flags at all.

lostmsu avatar Aug 14 '22 04:08 lostmsu

Could you confirm that with this change we can build --cuda_ext extension on Linux?

crcrpar avatar Aug 15 '22 17:08 crcrpar

Could you confirm if upgrading to use cuda 11.7 resolves the issue? It should be resolved in cuda based on comments: https://github.com/pytorch/pytorch/issues/69460#issuecomment-1278305417

ksmaze avatar Feb 20 '23 07:02 ksmaze

Likewise, does anyone know if this is resolved with CUDA 11.7 ?

NiallHornFX avatar Jul 29 '23 12:07 NiallHornFX