TransformerEngine
TransformerEngine copied to clipboard
Different dimension for attention
Description
I added channels_per_head
parameter to attention. I know that it is breaking change, but I think there is not a good way of doing it - look at the discussion in https://github.com/NVIDIA/TransformerEngine/pull/731
Fixes # (issue)
Type of change
- [ ] Documentation change (change only to the documentation, either a fix or a new content)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Changes
Please list the changes introduced in this PR:
- Added
channels_per_head
parameter to attention, - Added simple unit test, I don't know if its necessary
Checklist:
- [x] I have read and followed the contributing guidelines
- [x] The functionality is complete
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
But this tutorial mode change is good. Should I remove it and add to the new PR?
/te-ci pytorch
/te-ci pytorch
/te-ci pytorch
Why change the file permission for the tutorial?
It seems like we mistakenly changed the permission last time so I think we're reverting it back. Is that okay or do we need to create a separate fix for it?
/te-ci pytorch