TransformerEngine icon indicating copy to clipboard operation
TransformerEngine copied to clipboard

Find CXX component for MPI, fortran and C are not needed

Open aurianer opened this issue 9 months ago • 2 comments

Description

The default find_package is searching for all components. From the CMakeLists.txt I modified, you are linking only against MPI::MPI_CXX target. It is unnecessary to find the other C and Fortran mpi components.

Type of change

  • [ ] Documentation change (change only to the documentation, either a fix or a new content)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Cleanup

aurianer avatar May 01 '24 16:05 aurianer

Once the change is backported there, feel free to close this PR :)

aurianer avatar May 02 '24 12:05 aurianer

Another way might be to merge this PR and do a rebase on main, I don't think this would create any conflicts :)

aurianer avatar May 02 '24 12:05 aurianer