TransformerEngine icon indicating copy to clipboard operation
TransformerEngine copied to clipboard
verified publisher icon NVIDIA

Remove now useless padding as it is now down automatically.

Open nouiz opened this issue 1 year ago • 11 comments

nouiz avatar Feb 25 '24 02:02 nouiz

/te-ci jax

nouiz avatar Feb 25 '24 02:02 nouiz

/te-ci jax

nouiz avatar Feb 25 '24 03:02 nouiz

/te-ci jax

ksivaman avatar Feb 28 '24 15:02 ksivaman

@nouiz 0.4.16 was out on 18th September 2023, so with this change we're effectively supporting only 5 months of JAX releases, which seems too few

ksivaman avatar Feb 28 '24 15:02 ksivaman

/te-ci jax

denera avatar Feb 28 '24 20:02 denera

@nouiz 0.4.16 was out on 18th September 2023, so with this change we're effectively supporting only 5 months of JAX releases, which seems too few

Last summer, we where only supporting the last JAX release. That we now support 5 months is awesome! But I think as the JAX release cycle is very fast, 5 months is too much. I think 3 months (this is the normal JAX deprecation policy) is enough. But maybe in some cases, we won't be able to support that too.

I don't see 5 months as an issue blocking this PR. If you do, can you tell why?

nouiz avatar Feb 28 '24 21:02 nouiz

/te-ci jax

nouiz avatar Mar 06 '24 21:03 nouiz

/te-ci jax

ksivaman avatar Mar 07 '24 20:03 ksivaman

@nouiz Could you resolve the conflicts so that we can merge this?

ksivaman avatar Mar 18 '24 21:03 ksivaman

@nouiz Could you resolve the conflicts so that we can merge this?

done

nouiz avatar Mar 19 '24 03:03 nouiz

/te-ci jax

denera avatar Mar 27 '24 18:03 denera

After a discussion with @nouiz, we will re-open a fresh PR.

ksivaman avatar Jul 26 '24 20:07 ksivaman