TransformerEngine icon indicating copy to clipboard operation
TransformerEngine copied to clipboard

Add the examples and the tests in the installed packages.

Open nouiz opened this issue 2 years ago • 5 comments

This way, we don't need to keep the source directory to run all the tests and examples. This is small.

nouiz avatar Nov 10 '23 15:11 nouiz

/te-ci

nouiz avatar Nov 10 '23 15:11 nouiz

Note that one issue with this proposed approach is that the examples and tests folders will be directly placed in the Python site-packages folder alongside the transformer_engine engine. As such, it will not be obvious which software these folders belong to.

Maybe, they should be placed inside the transformer_engine folder?

yhtang avatar Nov 10 '23 16:11 yhtang

@nouiz The folder hierarchy should be correct now with the latest commit, but this involves turning examples into an importable submodule. I also migrated the JAX example-based unit tests out of the examples folder into the tests folder in order to avoid contaminating the new examples submodules with unit test classes. The QA scripts reflect this change.

Unit tests are copied over as "package data" so they're not importable. I didn't think it made much sense for them to be submodules.

denera avatar Nov 21 '23 03:11 denera

/te-ci jax

denera avatar Nov 21 '23 14:11 denera

/te-ci jax

denera avatar Nov 21 '23 18:11 denera

This PR is stale as it was created before the build system overhaul and as a result has several conflicts. After a discussion with @nouiz, we will re-open a fresh PR.

ksivaman avatar Jul 26 '24 20:07 ksivaman