TensorRT icon indicating copy to clipboard operation
TensorRT copied to clipboard

Fail early if output engine file path is unwritable in trtexec

Open PierreMarieCurie opened this issue 7 months ago • 10 comments

Hi NVIDIA team,

This PR adds an early check in trtexec to ensure the --saveEngine path is writable before starting ONNX parsing. It avoids unnecessary compute when the path is invalid. This a proposition to solve issue #4448.

It has only been tested on the following environment: Ubuntu 24.04 running as a Dev Container within WSL2.

Thanks!

PierreMarieCurie avatar May 19 '25 02:05 PierreMarieCurie

/blossom-ci

poweiw avatar Jul 02 '25 22:07 poweiw

/blossom-ci

poweiw avatar Jul 02 '25 23:07 poweiw

/blossom-ci

poweiw avatar Jul 02 '25 23:07 poweiw

Hello @PierreMarieCurie thanks for your contribution! Can you target the main branch and have your commits rebase on that?

poweiw avatar Jul 02 '25 23:07 poweiw

Hello @poweiw, thanks for your feedback. I've rebased my branch onto main and updated the PR to target it. Let me know if there's anything else you'd like adjusted.

PierreMarieCurie avatar Jul 03 '25 22:07 PierreMarieCurie

Thanks Pierre for the fast response! I lost my permission to trigger the pipeline but should be able to run next week. Will lyk with the pipeline results.

poweiw avatar Jul 03 '25 23:07 poweiw

/blossom-ci

poweiw avatar Jul 08 '25 22:07 poweiw

Hello @poweiw and @kevinch-nv, I messed up my rebase, sorry about that. The target branch was correct, but it was based on an old commit, so the pipeline failed. It should be fixed now.

PierreMarieCurie avatar Jul 09 '25 23:07 PierreMarieCurie

/blossom-ci

poweiw avatar Aug 12 '25 21:08 poweiw

Hello, any update on this MR when you get a chance? Thanks a lot!

PierreMarieCurie avatar Oct 01 '25 15:10 PierreMarieCurie