TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

[TRTLLM-6222][feat] enable cutedsl nvfp4 linear by default

Open zerollzeng opened this issue 1 month ago โ€ข 5 comments

Summary by CodeRabbit

  • Chores
    • Updated default optimization settings for linear layer computations.

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [x] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

zerollzeng avatar Nov 25 '25 03:11 zerollzeng

๐Ÿ“ Walkthrough

Walkthrough

The use_cute_dsl_nvfp4_blockscaling_mm parameter default in the Linear module's __init__ method was changed from False to True. This makes the NVFP4 blockscaling DSL computation path the default behavior for linear layer operations.

Changes

Cohort / File(s) Change Summary
Linear module parameter default
tensorrt_llm/_torch/modules/linear.py
Changed use_cute_dsl_nvfp4_blockscaling_mm parameter default from False to True in the Linear class __init__ method

Estimated code review effort

๐ŸŽฏ 1 (Trivial) | โฑ๏ธ ~2 minutes

  • Verify that changing this default does not break existing tests or expected behavior
  • Confirm the implications of enabling NVFP4 blockscaling DSL by default on performance and compatibility

Pre-merge checks and finishing touches

โŒ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check โš ๏ธ Warning The PR description is entirely blank except for the template structure. No actual description, test coverage, or rationale is provided. Add a clear description explaining the purpose of enabling cutedsl nvfp4 linear by default, list relevant test coverage, and confirm PR checklist items.
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
โœ… Passed checks (1 passed)
Check name Status Explanation
Title check โœ… Passed The title clearly describes the main change: enabling the cutedsl nvfp4 linear module by default in the Linear class initialization.
โœจ Finishing touches
  • [ ] ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

[!TIP]

๐Ÿ“ Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests โ€” including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. ๐Ÿ“ Description โ€” Summarize the main change in 50โ€“60 words, explaining what was done.
  2. ๐Ÿ““ References โ€” List relevant issues, discussions, documentation, or related PRs.
  3. ๐Ÿ“ฆ Dependencies & Requirements โ€” Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. ๐Ÿ“Š Contributor Summary โ€” Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
  5. โœ”๏ธ Additional Notes โ€” Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 25 '25 03:11 coderabbitai[bot]

/bot run

zerollzeng avatar Nov 25 '25 03:11 zerollzeng

@kaiyux for viz.

zerollzeng avatar Nov 25 '25 03:11 zerollzeng

PR_Github #25642 [ run ] triggered by Bot. Commit: b5b5d92

tensorrt-cicd avatar Nov 25 '25 03:11 tensorrt-cicd

PR_Github #25642 [ run ] completed with state SUCCESS. Commit: b5b5d92 /LLM/main/L0_MergeRequest_PR pipeline #19429 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 25 '25 04:11 tensorrt-cicd

/bot run

zerollzeng avatar Nov 26 '25 02:11 zerollzeng

PR_Github #25805 [ run ] triggered by Bot. Commit: 294a8f5

tensorrt-cicd avatar Nov 26 '25 02:11 tensorrt-cicd

PR_Github #25805 [ run ] completed with state SUCCESS. Commit: 294a8f5 /LLM/main/L0_MergeRequest_PR pipeline #19572 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 26 '25 03:11 tensorrt-cicd

/bot run

zerollzeng avatar Nov 26 '25 06:11 zerollzeng

/bot kill

zerollzeng avatar Nov 27 '25 01:11 zerollzeng

/bot run

zerollzeng avatar Nov 27 '25 01:11 zerollzeng

PR_Github #25916 [ kill ] triggered by Bot. Commit: 93e6ff5

tensorrt-cicd avatar Nov 27 '25 01:11 tensorrt-cicd

PR_Github #25916 [ kill ] completed with state SUCCESS. Commit: 93e6ff5 Successfully killed previous jobs for commit 93e6ff5

tensorrt-cicd avatar Nov 27 '25 01:11 tensorrt-cicd

PR_Github #25921 [ run ] triggered by Bot. Commit: 93e6ff5

tensorrt-cicd avatar Nov 27 '25 01:11 tensorrt-cicd

PR_Github #25921 [ run ] completed with state SUCCESS. Commit: 93e6ff5 /LLM/main/L0_MergeRequest_PR pipeline #19654 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 27 '25 03:11 tensorrt-cicd

/bot run

zerollzeng avatar Nov 27 '25 05:11 zerollzeng

PR_Github #25960 [ run ] triggered by Bot. Commit: 9298173

tensorrt-cicd avatar Nov 27 '25 05:11 tensorrt-cicd

PR_Github #25960 [ run ] completed with state SUCCESS. Commit: 9298173 /LLM/main/L0_MergeRequest_PR pipeline #19686 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 27 '25 09:11 tensorrt-cicd

/bot run

zerollzeng avatar Nov 27 '25 12:11 zerollzeng

PR_Github #26037 [ run ] triggered by Bot. Commit: 9298173

tensorrt-cicd avatar Nov 27 '25 12:11 tensorrt-cicd

PR_Github #26037 [ run ] completed with state SUCCESS. Commit: 9298173 /LLM/main/L0_MergeRequest_PR pipeline #19762 completed with status: 'SUCCESS'

tensorrt-cicd avatar Nov 27 '25 15:11 tensorrt-cicd

Hold this PR considering https://github.com/NVIDIA/TensorRT-LLM/pull/8963 should cover the functionality as well - let's keep tracking the status of that one.

kaiyux avatar Nov 28 '25 08:11 kaiyux