TensorRT-LLM Test

Summary by CodeRabbit

Release Notes

New Features
- Added CI-specific image tagging functionality for improved version management in continuous integration builds.
- Introduced dedicated CI build pipeline stages for streamlined workflow execution.
Improvements
- Optimized CI build process by refining pipeline stage execution logic.
- Enhanced git commit metadata handling for signed commits in CI workflows.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
[ ] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Nov 24 '25 08:11 ZhanruiSunCh

/bot run --disable-multi-gpu-test --skip-test

Nov 24 '25 08:11 ZhanruiSunCh

[!CAUTION]

Review failed

The head commit changed during the review from 794150fa284a2858581042282bc05693a2b7cc70 to af13e7b00f6d990f5239cd6e2ebc9196260e3f7e.

📝 Walkthrough

Walkthrough

Added CI-focused build mode to Jenkins Docker image pipeline. When MODE is set to "build_for_ci", the pipeline executes a new updateCIImageTag stage, restricts build configurations to CI entries, suppresses non-CI stages, and handles Git metadata for signed commits with CI-specific image tag updates.

Changes

Cohort / File(s) Summary

CI Build Mode Implementation
jenkins/BuildDockerImage.groovy Added global GITHUB_CREDENTIALS_ID and MODE variables. Introduced new updateCIImageTag() function for computing and persisting CI image tags, updating jenkins/current_image_tags.properties, and pushing changes to forked branch. Implemented conditional logic to restrict build configurations to CI entries when MODE == "build_for_ci", suppress non-CI stages (Upload Artifacts, Wait for Build Jobs Complete, Sanity Check, Security Checks), and enable new Update CI Image Tag stage. Enhanced Git metadata handling to parse Signed-off-by from latest commit and configure git credentials for signed commits.

Cohort / File(s)	Summary
CI Build Mode Implementation `jenkins/BuildDockerImage.groovy`	Added global `GITHUB_CREDENTIALS_ID` and `MODE` variables. Introduced new `updateCIImageTag()` function for computing and persisting CI image tags, updating `jenkins/current_image_tags.properties`, and pushing changes to forked branch. Implemented conditional logic to restrict build configurations to CI entries when `MODE == "build_for_ci"`, suppress non-CI stages (Upload Artifacts, Wait for Build Jobs Complete, Sanity Check, Security Checks), and enable new Update CI Image Tag stage. Enhanced Git metadata handling to parse Signed-off-by from latest commit and configure git credentials for signed commits.

Sequence Diagram(s)

sequenceDiagram
    participant Pipeline
    participant buildImage as buildImage()
    participant launchBuildJobs as launchBuildJobs()
    participant updateCIImageTag as updateCIImageTag()
    participant Git as Git/GitHub

    Pipeline->>Pipeline: Check MODE variable

    alt MODE == "build_for_ci"
        Pipeline->>buildImage: Filter configs to CI entries only
        activate buildImage
        buildImage->>buildImage: Build CI images
        deactivate buildImage
        
        Pipeline->>launchBuildJobs: Launch CI-specific jobs
        activate launchBuildJobs
        launchBuildJobs->>launchBuildJobs: Execute CI configs
        deactivate launchBuildJobs
        
        Pipeline->>updateCIImageTag: New stage: Update CI Image Tag
        activate updateCIImageTag
        updateCIImageTag->>Git: Parse Signed-off-by from commit
        updateCIImageTag->>Git: Configure git user
        updateCIImageTag->>Git: Compute CI image tags
        updateCIImageTag->>Git: Update current_image_tags.properties
        updateCIImageTag->>Git: Push to forked branch
        deactivate updateCIImageTag
    else MODE != "build_for_ci"
        Pipeline->>Pipeline: Execute standard pipeline flow
        Pipeline->>Pipeline: Include all stages (Artifacts, Sanity, Security, etc.)
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

updateCIImageTag function: Review new function logic for git metadata parsing, tag computation, and properties file updates
Conditional MODE logic: Verify correct filtering of build configurations and stage suppression across buildImage and launchBuildJobs functions
Git credential handling: Ensure Signed-off-by parsing and git configuration are correctly implemented
Stage orchestration: Confirm new stage integration and proper gating of existing stages based on MODE value

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete, containing only the template structure without filling in the required 'Description' and 'Test Coverage' sections with actual details about the changes.	Complete the Description section explaining the CI workflow changes, and add Test Coverage section listing relevant tests validating the new image tagging and build behavior.
Title check	❓ Inconclusive	The PR title 'Test' is vague and generic, lacking any specific information about the actual changes (CI image tag updates, Jenkins build workflow modifications, GitHub credentials handling).	Provide a descriptive title following the repository template, e.g., '[None][feat] Add CI image tag update workflow to BuildDockerImage' or use '@coderabbitai title' for auto-generation.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Nov 24 '25 08:11 coderabbitai[bot]

PR_Github #25529 [ run ] triggered by Bot. Commit: 665f7a2

Nov 24 '25 08:11 tensorrt-cicd

PR_Github #25529 [ run ] completed with state ABORTED. Commit: 665f7a2

Nov 24 '25 08:11 tensorrt-cicd

/bot run --disable-multi-gpu-test --skip-test

Nov 24 '25 09:11 ZhanruiSunCh

PR_Github #25543 [ run ] triggered by Bot. Commit: 665f7a2

Nov 24 '25 09:11 tensorrt-cicd

PR_Github #25543 [ run ] completed with state ABORTED. Commit: 665f7a2

Nov 24 '25 10:11 tensorrt-cicd

PR_Github #5 [ run ] triggered by Bot. Commit: 665f7a2

Nov 24 '25 10:11 tensorrt-cicd

PR_Github #5 [ run ] completed with state FAILURE. Commit: 665f7a2 Build Docker Images Pipeline #1209 failed

Nov 24 '25 10:11 tensorrt-cicd

@ZhanruiSunCh is this PR meant for review? I see the subject is "Test".

Nov 24 '25 17:11 zeroepoch

@ZhanruiSunCh is this PR meant for review? I see the subject is "Test".

Not, Sorry, I forget add Draft for it.

Nov 27 '25 07:11 ZhanruiSunCh

PR_Github #17 [ run ] triggered by Bot. Commit: 4e8920e

Nov 28 '25 06:11 tensorrt-cicd

PR_Github #17 [ run ] completed with state ABORTED. Commit: 4e8920e LLM/PipelineMonitor/L0_MergeRequest_PR #4 (Blue Ocean) completed with status: ABORTED

Nov 28 '25 06:11 tensorrt-cicd

/bot run --disable-multi-gpu-test --skip-test

Nov 28 '25 06:11 ZhanruiSunCh

PR_Github #26127 [ run ] triggered by Bot. Commit: 4e8920e

Nov 28 '25 06:11 tensorrt-cicd

PR_Github #26127 [ run ] completed with state ABORTED. Commit: 4e8920e LLM/main/L0_MergeRequest_PR #19843 (Blue Ocean) completed with status: ABORTED