TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

[None][fix] Fix on-disk cache and revise logger/statistics for AutoTuner.

Open hyukn opened this issue 1 month ago โ€ข 49 comments

  • Add a specific environment variable to control the logger level of AutoTuner.
  • Add statistics to track the total profiling time for each op. This will help determine the dominating op during warm-up tuning.
  • Always enabled tuning w/. or w/o. loading serialized cache.
  • Fixed fallback issues when using serialization/deserialization cache.

Summary by CodeRabbit

Release Notes

  • New Features

    • Autotuner now tracks and displays per-operation timing costs within statistics output
    • Debug logging enhanced with environment variable configuration for improved diagnostics
  • Chores

    • Added statistics output emission following autotuner warmup profiling

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [x] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

hyukn avatar Nov 17 '25 07:11 hyukn

๐Ÿ“ Walkthrough

Walkthrough

The PR adds timing instrumentation and enhanced logging to the autotuner module. It introduces per-operation time cost tracking via a new tuned_op_time_cost field, a configurable debug logger driven by an environment variable, updated statistics reporting, and a public print_statistics() method. A new statistics output call is added to the model engine's autotuner warmup sequence.

Changes

Cohort / File(s) Summary
Autotuner Core Enhancements
tensorrt_llm/_torch/autotuner.py
Added tuned_op_time_cost field to track per-operation durations; introduced _debug_logger with TLLM_AUTOTUNER_LOG_LEVEL_DEBUG_TO_INFO env var configuration; added tuning_start_time and tuning_end_time tracking in profiling flows; refactored logging calls to use new debug logger and conditional info routing; updated AutoTunerStatistics.__str__ to display time costs in milliseconds; added print_statistics() public method; enhanced cache existence check with rank-specific logic.
Runtime Instrumentation
tensorrt_llm/_torch/pyexecutor/model_engine.py
Added call to AutoTuner.get().print_statistics() following profiling cache printout in autotuner warmup sequence.
Test Updates
tests/unittest/_torch/misc/test_autotuner.py
Added calls to AutoTuner.get().print_profiling_cache() and AutoTuner.get().print_statistics() in test_autotuner_cache_basic to exercise statistics and cache printing functionality.

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

  • Environment variable interaction: Verify that TLLM_AUTOTUNER_LOG_LEVEL_DEBUG_TO_INFO behavior integrates correctly with existing logging configuration and doesn't cause conflicts.
  • Timing accumulation logic: Confirm that tuning_start_time and tuning_end_time are correctly captured and accumulated across profiling flows.
  • Rank-specific cache check: Ensure the new file-existence-based decision logic for enabling tuning is functionally equivalent and preserves expected behavior for multi-rank scenarios.

Pre-merge checks and finishing touches

โŒ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 56.25% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check โš ๏ธ Warning The title mentions 'fix on-disk cache' but the changes focus on logger/statistics revisions and profiling instrumentation, not cache fixes. Align the title with the actual changes. Consider revising to: '[None][chore] Revise logger and statistics for AutoTuner' to match the PR objectives and actual implementation.
Description check โ“ Inconclusive The PR description is incomplete and vague; it lists features but lacks implementation details, rationale, and comprehensive test coverage documentation. Expand the description section to explain the 'why' behind changes, provide implementation details for each feature point, clearly document all test cases covering new functionality, and explicitly explain what fallback issues were fixed.
โœจ Finishing touches
  • [ ] ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

[!TIP]

๐Ÿ“ Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests โ€” including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. ๐Ÿ“ Description โ€” Summarize the main change in 50โ€“60 words, explaining what was done.
  2. ๐Ÿ““ References โ€” List relevant issues, discussions, documentation, or related PRs.
  3. ๐Ÿ“ฆ Dependencies & Requirements โ€” Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. ๐Ÿ“Š Contributor Summary โ€” Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
  5. โœ”๏ธ Additional Notes โ€” Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 17 '25 08:11 coderabbitai[bot]

/bot run

hyukn avatar Nov 17 '25 13:11 hyukn

PR_Github #24767 [ run ] triggered by Bot. Commit: 4293393

tensorrt-cicd avatar Nov 17 '25 13:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 17 '25 14:11 hyukn

PR_Github #24772 [ run ] triggered by Bot. Commit: e64e99d

tensorrt-cicd avatar Nov 17 '25 14:11 tensorrt-cicd

PR_Github #24767 [ run ] completed with state ABORTED. Commit: 4293393 LLM/main/L0_MergeRequest_PR #18684 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd avatar Nov 17 '25 14:11 tensorrt-cicd

PR_Github #24772 [ run ] completed with state SUCCESS. Commit: e64e99d /LLM/main/L0_MergeRequest_PR pipeline #18689 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 18 '25 03:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 18 '25 03:11 hyukn

PR_Github #24836 [ run ] triggered by Bot. Commit: e64e99d

tensorrt-cicd avatar Nov 18 '25 03:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 18 '25 05:11 hyukn

PR_Github #24851 [ run ] triggered by Bot. Commit: cdf36dd

tensorrt-cicd avatar Nov 18 '25 05:11 tensorrt-cicd

PR_Github #24836 [ run ] completed with state ABORTED. Commit: e64e99d LLM/main/L0_MergeRequest_PR #18746 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd avatar Nov 18 '25 05:11 tensorrt-cicd

PR_Github #24851 [ run ] completed with state SUCCESS. Commit: cdf36dd /LLM/main/L0_MergeRequest_PR pipeline #18759 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 18 '25 23:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 19 '25 01:11 hyukn

PR_Github #24965 [ run ] triggered by Bot. Commit: cdf36dd

tensorrt-cicd avatar Nov 19 '25 01:11 tensorrt-cicd

PR_Github #24965 [ run ] completed with state FAILURE. Commit: cdf36dd /LLM/main/L0_MergeRequest_PR pipeline #18859 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 19 '25 06:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 19 '25 14:11 hyukn

PR_Github #25063 [ run ] triggered by Bot. Commit: e1b4c39

tensorrt-cicd avatar Nov 19 '25 14:11 tensorrt-cicd

PR_Github #25063 [ run ] completed with state SUCCESS. Commit: e1b4c39 /LLM/main/L0_MergeRequest_PR pipeline #18942 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 19 '25 20:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 20 '25 02:11 hyukn

PR_Github #25126 [ run ] triggered by Bot. Commit: e1b4c39

tensorrt-cicd avatar Nov 20 '25 02:11 tensorrt-cicd

PR_Github #25126 [ run ] completed with state SUCCESS. Commit: e1b4c39 /LLM/main/L0_MergeRequest_PR pipeline #18994 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 20 '25 07:11 tensorrt-cicd

/bot run

qiaoxj07 avatar Nov 20 '25 12:11 qiaoxj07

PR_Github #25204 [ run ] triggered by Bot. Commit: e1b4c39

tensorrt-cicd avatar Nov 20 '25 12:11 tensorrt-cicd

PR_Github #25204 [ run ] completed with state SUCCESS. Commit: e1b4c39 /LLM/main/L0_MergeRequest_PR pipeline #19059 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 20 '25 21:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 21 '25 01:11 hyukn

PR_Github #25265 [ run ] triggered by Bot. Commit: 150387a

tensorrt-cicd avatar Nov 21 '25 01:11 tensorrt-cicd

PR_Github #25265 [ run ] completed with state ABORTED. Commit: 150387a LLM/main/L0_MergeRequest_PR #19113 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd avatar Nov 21 '25 05:11 tensorrt-cicd

/bot run --disable-fail-fast

hyukn avatar Nov 21 '25 07:11 hyukn

PR_Github #25328 [ run ] triggered by Bot. Commit: 14bfff9

tensorrt-cicd avatar Nov 21 '25 07:11 tensorrt-cicd