TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

infra: Devcontainer productivity improvements

Open lucaslie opened this issue 9 months ago • 4 comments

Adding a few productivity improvements to our devcontainer setup

  • [x] Expose all GPUs in docker-compose
  • [x] Auto-mount HuggingFace Hub cache if available
  • [x] Pre-install requirements and pre-commit hooks
  • [x] Move .devcontainer/clangd/devcontainer.json --> .devcontainer/devcontainer.json. background: some VSCode commands like >Dev Container: Clone Repository in Container Volume... only work with .devcontainer/devcontainer.json. If we ever split our devcontainer setup between clangd and python or others we can move it back but for now it can add additional convenience
  • [x] Ensure python path is correctly specified for VSCode
  • [ ] Double-check pre-commit install in post create command (got some issue in one my tests)

lucaslie avatar Mar 25 '25 20:03 lucaslie

/bot run

lucaslie avatar Mar 25 '25 20:03 lucaslie

PR_Github #466 [ run ] triggered by Bot

niukuo avatar Mar 25 '25 20:03 niukuo

PR_Github #466 [ run ] completed with state SUCCESS /LLM/main/L0_MergeRequest_PR pipeline #399 completed with status: 'SUCCESS'

niukuo avatar Mar 25 '25 22:03 niukuo

@lucaslie Thanks for improving the dev productivity!

@niukuo Since this is container related change, can you also help review this MR?

June

juney-nvidia avatar Mar 26 '25 00:03 juney-nvidia

/bot run

lucaslie avatar Apr 01 '25 22:04 lucaslie

/bot run

lucaslie avatar Apr 01 '25 23:04 lucaslie

PR_Github #929 [ run ] triggered by Bot

tensorrt-cicd avatar Apr 01 '25 23:04 tensorrt-cicd

/bot run

lucaslie avatar Apr 01 '25 23:04 lucaslie

PR_Github #933 [ run ] triggered by Bot

tensorrt-cicd avatar Apr 01 '25 23:04 tensorrt-cicd

PR_Github #929 [ run ] completed with state ABORTED

tensorrt-cicd avatar Apr 01 '25 23:04 tensorrt-cicd

PR_Github #933 [ run ] completed with state SUCCESS /LLM/main/L0_MergeRequest_PR pipeline #735 completed with status: 'SUCCESS'

tensorrt-cicd avatar Apr 02 '25 01:04 tensorrt-cicd

Not sure why I cannot rebase this branch, I don't have the button on UI. Hence I cannot merge it.

kaiyux avatar Apr 02 '25 16:04 kaiyux

/bot reuse-pipeline

lucaslie avatar Apr 02 '25 18:04 lucaslie

Not sure why I cannot rebase this branch, I don't have the button on UI. Hence I cannot merge it.

@kaiyux, thank you for checking. Probably you don't have write access to the fork? Also, I have merge permissions so should be good. :)

lucaslie avatar Apr 02 '25 18:04 lucaslie

PR_Github #1037 [ reuse-pipeline ] triggered by Bot

tensorrt-cicd avatar Apr 02 '25 18:04 tensorrt-cicd

PR_Github #1037 [ reuse-pipeline ] completed with state SUCCESS Reusing PR_Github #933 for commit 1577979

tensorrt-cicd avatar Apr 02 '25 18:04 tensorrt-cicd