TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

fix: The constructor checks useDynamicTree but doesn’t validate dynamicTreeMaxTopK if set

Open A-transformer opened this issue 9 months ago • 8 comments

The check is tied to mDynamicTreeMaxTopK, which is only meaningful in the context of useDynamicTree. While the check could theoretically apply even when useDynamicTree is false, enforcing it here ensures it’s validated at construction time alongside related conditions.

A-transformer avatar Mar 21 '25 17:03 A-transformer

/bot run

kaiyux avatar Mar 24 '25 02:03 kaiyux

PR_Github #212 [ run ] triggered by Bot

niukuo avatar Mar 24 '25 02:03 niukuo

PR_Github #212 [ run ] completed with state FAILURE /LLM/main/L0_MergeRequest_PR pipeline #224 completed with status: 'FAILURE'

niukuo avatar Mar 24 '25 02:03 niukuo

@byshiue @lfr-0531 can you help review this MR?

Thanks June

juney-nvidia avatar Mar 24 '25 04:03 juney-nvidia

/bot run

lfr-0531 avatar Mar 24 '25 05:03 lfr-0531

PR_Github #242 [ run ] triggered by Bot

niukuo avatar Mar 24 '25 05:03 niukuo

PR_Github #242 [ run ] completed with state SUCCESS /LLM/main/L0_MergeRequest_PR pipeline #239 completed with status: 'SUCCESS'

niukuo avatar Mar 24 '25 09:03 niukuo

@A-transformer The DCO check failed with the error message

Expected "A-transformer [[email protected]](mailto:[email protected])", but got "root [[email protected]](mailto:[email protected])"."

Can you help fix it?

kaiyux avatar Mar 24 '25 09:03 kaiyux

Closing as no activities from requester for +10 days. Feel free to reopen 👍

poweiw avatar Jun 05 '25 19:06 poweiw