NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Update TransformerEngine initialize_ub parameters

Open thomasdhc opened this issue 1 year ago • 2 comments

What does this PR do ?

Update TransformerEngine and update paramters of initialize_ub function

Collection: [nlp]

Changelog

  • Update parameter tp_size to tp_group in initialize_ub

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

thomasdhc avatar Jun 25 '24 18:06 thomasdhc

TE PR that updated the parameters: https://github.com/NVIDIA/TransformerEngine/pull/901

thomasdhc avatar Jun 25 '24 18:06 thomasdhc

CI passed (test that failed flaky & is now fixed): https://github.com/NVIDIA/NeMo/actions/runs/9702489435

pablo-garay avatar Jun 27 '24 23:06 pablo-garay

This change is no longer needed with new TE changes: https://github.com/NVIDIA/TransformerEngine/pull/986

thomasdhc avatar Jul 03 '24 17:07 thomasdhc