NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Support Canary parallel inference

Open karpnv opened this issue 1 year ago • 4 comments

What does this PR do ?

Support Canary at transcribe_speech_parallel.py script

Collection: ASR

#python3 ./examples/asr/transcribe_speech_parallel.py model=./canary-1b.nemo predict_ds.manifest_filepath=./manifest.json output_path=/tmp trainer.devices=-1

PR Type:

  • [ V] New Feature
  • [ ] Bugfix
  • [ ] Documentation

Who can review?

@pzelasko

karpnv avatar Jun 21 '24 13:06 karpnv

+ like we talked offline, we have to work around global_rank being set incorrectly before trainer.predict() is called - the dataloader has to be initialized with the correct global_rank (and world_size) in order for lhotse's distributed sampler to work correctly

pzelasko avatar Jun 24 '24 15:06 pzelasko

trainer.global_rank is apriori set by PTL in slurm environment. It does not require model to be built or it's functions to be called c

Is this a case where PTL cannot apriori detect global rank ?

titu1994 avatar Jun 24 '24 19:06 titu1994

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jul 16 '24 01:07 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jul 24 '24 01:07 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Sep 08 '24 01:09 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Sep 15 '24 02:09 github-actions[bot]

Jenkins

karpnv avatar Sep 27 '24 15:09 karpnv

[🤖]: Hi @karpnv 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

github-actions[bot] avatar Sep 27 '24 15:09 github-actions[bot]

[🤖]: Hi @karpnv 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

github-actions[bot] avatar Sep 27 '24 18:09 github-actions[bot]

[🤖]: Hi @karpnv 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

github-actions[bot] avatar Sep 27 '24 21:09 github-actions[bot]