NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward

Open galv opened this issue 1 year ago • 0 comments

GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do.

Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly.

What does this PR do ?

Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward

Collection: ASR

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [X] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

galv avatar May 17 '24 22:05 galv