NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

✨ Add more common text metrics from torchmetrics.

Open jacklanda opened this issue 1 year ago • 1 comments

What does this PR do ?

Simply, add more common text metrics from torchmetrics. It takes me long time to find out how to add more common text-based metrics for validation measurement in NeMo, and I hope this PR could help more people to get to know that ``Yes, we can leverage more auto metrics directly from torchmetrics.''.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [x] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [x] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

jacklanda avatar May 10 '24 12:05 jacklanda

Could anyone take a quick glance at it?

jacklanda avatar May 13 '24 03:05 jacklanda

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar May 28 '24 01:05 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jun 04 '24 01:06 github-actions[bot]

Shit hole.

jacklanda avatar Jun 04 '24 03:06 jacklanda