NeMo
NeMo copied to clipboard
Bucketing duration bins: less optimal but instant init when not provided + fixes in estimation script
What does this PR do ?
- speed-up in training start when duration bins are not provided (we will assume uniform split to num_buckets - 1 bins over the span of [min_duration - max_duration])
-
scripts/speech_recognition/estimate_duration_bins.py- support more data input flags supported by NeMo training configs
- a lot of fixes to various edge cases and excessive memory usage...
- renamed
missing_sampling_rate_okoption inLhotseDataLoadingConfigtometadata_onlyand broadened its scope to prevent the construction of an infinite iterator over data (there was no way to get a precise bin estimate in multi-dataset setups before)
Collection: ASR
Changelog
- Add specific line by line info of high level changes in this PR.
Usage
- You can potentially add a usage example below
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
- [ ] Make sure you read and followed Contributor guidelines
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
PR Type:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
- Related to # (issue)