NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

fix canary chunk infer bug

Open stevehuang52 opened this issue 1 year ago • 3 comments

What does this PR do ?

fix canary chunk infer bug, where the last segment might have mismatched shape with pre-allocated buffer.

stevehuang52 avatar Feb 17 '24 01:02 stevehuang52

jenkins

stevehuang52 avatar Feb 17 '24 02:02 stevehuang52

jenkins

stevehuang52 avatar Feb 17 '24 02:02 stevehuang52

jenkins

stevehuang52 avatar Feb 17 '24 14:02 stevehuang52

jenkins

stevehuang52 avatar Feb 19 '24 17:02 stevehuang52

could you add unit tests that cover these edge cases? btw I didn't see that PR earlier and added the relative audio path support independently; we can either merge my PR or port the test I wrote to yours and close mine (up to you) https://github.com/NVIDIA/NeMo/pull/8464

pzelasko avatar Feb 20 '24 16:02 pzelasko

could you add unit tests that cover these edge cases? btw I didn't see that PR earlier and added the relative audio path support independently; we can either merge my PR or port the test I wrote to yours and close mine (up to you) #8464

Sure I'll add the tests~I think it's better to use the get_full_path function to resolve the relative paths, since it's well tested.

stevehuang52 avatar Feb 20 '24 16:02 stevehuang52

jenkins

stevehuang52 avatar Feb 20 '24 16:02 stevehuang52

jenkins

stevehuang52 avatar Feb 20 '24 21:02 stevehuang52

jenkins

stevehuang52 avatar Feb 21 '24 16:02 stevehuang52

jenkins

stevehuang52 avatar Feb 22 '24 15:02 stevehuang52