NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Handle in HF AutoTokenizer with pad_token=None

Open HuiyingLi opened this issue 1 year ago • 6 comments

What does this PR do ?

In the NML data preprocessing script scripts/nlp_language_modeling/preprocess_data_for_megatron.py the builder the pad_id thru: pad_id=tokenizer.pad_id if hasattr(tokenizer, "pad_id") else 0

While HF wrapper AutoTokenizer class has pad_id as a property, but doesn't actually have pad_token, which will throw None error. This pr checks if special token exists before encode to get ID of special token.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

HuiyingLi avatar Dec 20 '23 22:12 HuiyingLi

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jan 04 '24 01:01 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jan 11 '24 01:01 github-actions[bot]

Is it possible to reopen the pr?

HuiyingLi avatar Jan 12 '24 05:01 HuiyingLi

jenkins

cuichenx avatar Jan 25 '24 00:01 cuichenx

@yaoyu-33 Could you review the resolved issue and say jenkins again? Thanks!!

HuiyingLi avatar Feb 06 '24 20:02 HuiyingLi

jenkins

yaoyu-33 avatar Feb 12 '24 19:02 yaoyu-33

jenkins

yaoyu-33 avatar Feb 20 '24 17:02 yaoyu-33

jenkins

yaoyu-33 avatar Feb 23 '24 18:02 yaoyu-33