NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

[TTS] Condition FastPitch on Energy

Open subhankar-ghosh opened this issue 2 years ago • 1 comments

What does this PR do ?

Adds support for Conditioning FastPitch model on Energy

Collection: [Note which collection this PR will affect]

nemo/collections/tts/

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [x] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

subhankar-ghosh avatar Sep 20 '22 07:09 subhankar-ghosh

Haven't dived too deep for this PR, will do later today. A general question, is there any way we could add a unit test to validate if energy computation and its masking strategy work as expected? We could mock tensors or use real tensors from audio.

XuesongYang avatar Sep 20 '22 17:09 XuesongYang

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 14 '22 02:10 github-actions[bot]

Breaking due to https://github.com/NVIDIA/NeMo/pull/5176

subhankar-ghosh avatar Oct 15 '22 20:10 subhankar-ghosh