NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Ssl tts final

Open shehzeen opened this issue 2 years ago • 2 comments

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

shehzeen avatar Sep 12 '22 02:09 shehzeen

This pull request introduces 30 alerts when merging 27b5433c07dfaba27b8491d399eb041e562233e9 into efc0c0418644b317b24218680c2ee3f311bc5fe0 - view on LGTM.com

new alerts:

  • 23 for Unused import
  • 2 for Unused local variable
  • 2 for Variable defined multiple times
  • 1 for First parameter of a method is not named 'self'
  • 1 for Mismatch in multiple assignment
  • 1 for Duplicate key in dict literal

lgtm-com[bot] avatar Sep 14 '22 19:09 lgtm-com[bot]

This pull request introduces 30 alerts when merging a715bdc92cbea4e6edc20ad7d43b52b73cd4ae60 into f1825bc4b724b78c2d6ca392b616e8dc9a8cde04 - view on LGTM.com

new alerts:

  • 23 for Unused import
  • 2 for Unused local variable
  • 2 for Variable defined multiple times
  • 1 for First parameter of a method is not named 'self'
  • 1 for Mismatch in multiple assignment
  • 1 for Duplicate key in dict literal

lgtm-com[bot] avatar Sep 14 '22 23:09 lgtm-com[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 14 '22 02:10 github-actions[bot]

@redoctopus @blisc this PR will be closed soon. Are we planning to merge to NeMo? I bet this is the final internship work.

XuesongYang avatar Oct 18 '22 17:10 XuesongYang

@redoctopus @blisc this PR will be closed soon. Are we planning to merge to NeMo? I bet this is the final internship work.

Yes--it's a large PR, so we were planning to start reviewing it next week in earnest when we have more time. Don't worry, it's not forgotten!

redoctopus avatar Oct 18 '22 17:10 redoctopus

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Nov 03 '22 02:11 github-actions[bot]

Looks like there are some conflicts since some of the segmenting changes had already been integrated previously. Could you fix those?

redoctopus avatar Dec 16 '22 18:12 redoctopus

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Dec 31 '22 01:12 github-actions[bot]