NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

Riva itn 2.0

Open anand-nv opened this issue 2 years ago • 4 comments

What does this PR do ?

Update TN and ITN for ES to 2.0, add en_in (EN International, current Riva EN ITN 2.0)

Collection: nemo_text_processing

Changelog

Add en_in ITN (current Riva EN ITN 2.0) Update ES for TN and ITN to 2.0

PR Type:

  • [X ] New Feature
  • [X ] Bugfix

anand-nv avatar Aug 29 '22 03:08 anand-nv

This pull request introduces 4 alerts when merging 3afab15564214cbe6add1f8a5e5e51e9a5df673e into f85494cf2b288c6c9eda006cd08d86af46251700 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Aug 29 '22 03:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging e7f4d8334a17c4ad3183aac356d7b5246cb5c773 into d9691628a89489e2d0a560894809c2667df65a12 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Aug 29 '22 21:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging b1bc87267021bc272e1c664569289827e5a79bb5 into a08e6d90a6281ada9cf2eba2e214d1f4625572c8 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Aug 30 '22 14:08 lgtm-com[bot]

thanks for PR. Please fix the alerts as detected by LGTM.com.

XuesongYang avatar Sep 09 '22 01:09 XuesongYang

This pull request introduces 4 alerts when merging 35ef62f824098612c30200534cc5834d0d1baaec into be4c662500bf797c345bb0f4d4b17d251293f009 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 01 '22 04:10 lgtm-com[bot]

@anand-nv, any updates on the PR? Will you merge en_in into en?

ekmb avatar Oct 03 '22 17:10 ekmb

This pull request introduces 4 alerts when merging f6018e363903330bd4969102dc972a668a279417 into cb2793c0c7bb352e1dfd8c349a96efc1dd260179 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 03 '22 18:10 lgtm-com[bot]

Please add test cases for the new rules to NeMo/tree/main/tests/nemo_text_processing//*/*.txt

erastorgueva-nv avatar Oct 03 '22 21:10 erastorgueva-nv

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 18 '22 02:10 github-actions[bot]

This pull request introduces 4 alerts when merging 50f86a943c70aefb63623279b23f5da55ddcc48c into b4011ec1fb9b824673b0dd78c8aabc1c8ca2470e - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 18 '22 15:10 lgtm-com[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Nov 03 '22 02:11 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Nov 22 '22 02:11 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Nov 30 '22 02:11 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Dec 22 '22 01:12 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Dec 29 '22 01:12 github-actions[bot]