Megatron NMT Adapters

[Davood-M]

Signed-off-by: David Mosallanezhad [email protected]

What does this PR do ?

Megatron NMT Adapters

Collection: [Note which collection this PR will affect]

Changelog

• Add specific line by line info of high level changes in this PR.

Usage

• You can potentially add a usage example below

# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

• [X] Make sure you read and followed Contributor guidelines
• [ ] Did you write any new necessary tests?
• [ ] Did you add or update any necessary documentation?
• [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

• [X] New Feature
• [ ] Bugfix
• [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

• Related to # (issue)

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 227a596c1efa130a0e10dd571c4d8975e23509a8 into 4d3e33588f2c2a61253d4843904959ee38eb9687 - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 83d0770c59be22cdd4acff8b14bb92f49c6f31cd into 0e57b58a849f6275629910cdeebd608e528327bf - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 30f422e72b07242dc10ade3b2c9ba68c1e87985a into f98fcbf197d2a15ba8dbf015486c438862417c8b - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging b142e38d1a10caff3de6150e4a6d657808967009 into f85494cf2b288c6c9eda006cd08d86af46251700 - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 4 alerts when merging 8ba394f185e10c975c2ebb6346be6cfb8627aca2 into d9691628a89489e2d0a560894809c2667df65a12 - view on LGTM.com

new alerts:

• 3 for Unused import
• 1 for Unused local variable

[MaximumEntropy]

Can you move adapter class wrapper MegatronAdapterNMTModel higher in class hierarchy so that T5 and UL2 get it as well? cc @MaximumEntropy

Agreed! @Davood-M can you make this adapter class based on MegatronLMEncoderDecoderModel? That is shared by T5/BART/UL2/NMT

[lgtm-com[bot]]

This pull request introduces 6 alerts when merging 1bc1117f893f3188411e02a8a7b0566b2201ccfa into e8ba60b648ae0fe04ca46d93a4d9e0f6537b521d - view on LGTM.com

new alerts:

• 3 for Unused import
• 2 for Wrong name for an argument in a class instantiation
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 6 alerts when merging d5477711259a5e827119202367e10b683f4c5f18 into e8ba60b648ae0fe04ca46d93a4d9e0f6537b521d - view on LGTM.com

new alerts:

• 3 for Unused import
• 2 for Wrong name for an argument in a class instantiation
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 5 alerts when merging 097e8ed10218601bd7f3ca294bfe325003de597b into 1c16b966299203392aaba73090d820376a291974 - view on LGTM.com

new alerts:

• 4 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 5 alerts when merging 6e0354d0e6346e82efd228995e5e9381826a4639 into 1c16b966299203392aaba73090d820376a291974 - view on LGTM.com

new alerts:

• 4 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 5 alerts when merging 27b26f7e5372a861ce4adda68b4680473bf0984d into 1c16b966299203392aaba73090d820376a291974 - view on LGTM.com

new alerts:

• 4 for Unused import
• 1 for Unused local variable

[Davood-M]

Updated the class to MegatronLMEncoderDecoder. I will start cleaning up the code and removing unnecessary sections.

[lgtm-com[bot]]

This pull request introduces 6 alerts when merging 25e50a4cde8403f92565d4a9f421c1c40edd5a31 into 903fb0b9cb44f2fd1e111d67ab389b06d90ad585 - view on LGTM.com

new alerts:

• 5 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging a782013b6d3ae960f82a7e7a41ffc8197499466d into b18f9057e83d711e7bf0b36c8494a1d3be093394 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging d533e161afebce7ace2f41826d0f0af8e09eedc7 into f1825bc4b724b78c2d6ca392b616e8dc9a8cde04 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging d11082bdd2e2d3308c55a318255848aa98d159e2 into e872061accf2534a8b8f4542e05c5887bcfdecda - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging 8b63fe9472dc5d39fa7a6c6553e95476c92e33e6 into e872061accf2534a8b8f4542e05c5887bcfdecda - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging 04cee3d214ef0065ce8dbe54eff304f7ed509827 into cb2793c0c7bb352e1dfd8c349a96efc1dd260179 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging 5f23f089516637b6fb8407581e7c8ea2ace37dce into e0cc6b76766f6f1f933be5f798d86fb1a5edd3ee - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging 4c4422a93d837eda38a4dae53a40d416975b6ecf into 091bcadb0b581dd553f02e706471aafe8e6f2f22 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging add7ab80bfe8a6504c1b888435e696c9f442435e into 3fda5de46d9e5e3a55c18449a88665f80c34899f - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging 48a324da4da75f0542ce2455341b03eb69635724 into 197829405ded0d518adb7f1af763d9f18d253891 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[lgtm-com[bot]]

This pull request introduces 8 alerts when merging a9bf64c6e377244e97a1a543cb995b9a342b2f6a into 4366699989cc318f9de1873d795e7bb3175cc566 - view on LGTM.com

new alerts:

• 7 for Unused import
• 1 for Unused local variable

[github-actions[bot]]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

[github-actions[bot]]

This PR was closed because it has been inactive for 7 days since being marked as stale.