NeMo
NeMo copied to clipboard
Fix setting up of `ReduceLROnPlateau` learning rate scheduler
What does this PR do ?
Fix setting up of ReduceLROnPlateau
learning rate scheduler.
Collection: core
Steps to reproduce
git clone https://github.com/NVIDIA/NeMo.git
cd NeMo
git checkout fix/reduce_on_plateau_r1.11.0
git checkout r1.11.0 -- nemo/core/optim/lr_scheduler.py nemo/core/config/schedulers.py
pytest tests/core/test_optimizers_schedulers.py
Before your PR is "Ready for review"
Pre checks:
- [ ] Make sure you read and followed Contributor guidelines
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
PR Type:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
- Related to # (issue)