NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Add option to save VAD artifacts

Open findkim opened this issue 2 years ago • 2 comments

What does this PR do ?

  • Adds utility option to save input and output tensors for VAD model inference useful for testing and comparison in isolation from pre/post processing
  • Adds support to disable median filtering for VAD post processing, (None, False, '')

Collection: ASR

Changelog

  • Add VAD options to save artifacts and disable median filtering

Usage

examples/asr/conf/vad/vad_inference_postprocessing.yaml

vad:
    parameters:
      smoothing: None
save_artifacts: False

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [x] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [x] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

findkim avatar Jul 26 '22 16:07 findkim

@findkim Could you please run code linter and merge the PR? python setup.py style --fix

fayejf avatar Sep 12 '22 07:09 fayejf

thank @fayejf ! I linted and merged in main

findkim avatar Sep 12 '22 16:09 findkim

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 13 '22 02:10 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Oct 21 '22 02:10 github-actions[bot]