NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

[TTS] fix for #4105 and #4100

Open itzsimpl opened this issue 3 years ago • 3 comments

Signed-off-by: Iztok Lebar Bajec [email protected]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [x] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

itzsimpl avatar May 04 '22 12:05 itzsimpl

@blisc @okuchaiev could someone review?

itzsimpl avatar May 11 '22 08:05 itzsimpl

@borisfom @titu1994 Why does this script even exist in the repo?

blisc avatar May 11 '22 16:05 blisc

As far as I remember, it's to standardize the use of export path for all models so that users don't have to write their own one off scripts to load a model and call export with xyz flags c

titu1994 avatar May 12 '22 16:05 titu1994

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Oct 07 '22 02:10 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Oct 14 '22 02:10 github-actions[bot]