NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Fix feature extractor to be invariant to padding

Open pzelasko opened this issue 7 months ago • 0 comments

What does this PR do ?

Adds tests and fixes inconsistency in ASR feature extractor when processing the same input with and without padding. Specifically:

  • removes a Dirac-delta-like spike due to lack of masking in preemphasis (only present when audio_length < audio.shape["time"])
  • replaces "reflect" padding with zero-padding for padding-length-invariance

I tested the changes on HF leaderboard with canary-180m-flash (offline model) and saw no significant change (actually the overall WER improved -0.01% to 7.11%).

This doesn't entirely solve the issue of numerical differences between padded and non-padded examples with Conformer models (especially offline ones), and needs follow-up on ConformerEncoder to fully resolve.

Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

pzelasko avatar Jun 04 '25 15:06 pzelasko