NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Multi node settings for evaluation nemo-run script

Open athitten opened this issue 7 months ago • 3 comments

[!IMPORTANT]
The Update branch button must only be pressed in very rare occassions. An outdated branch is never blocking the merge of a PR. Please reach out to the automation team before pressing that button.

What does this PR do ?

Minor edits to scripts/llm/evaluation.py to support evaluation of model on multi node.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

athitten avatar May 13 '25 22:05 athitten

@chtruong814 can we fast-merge this once @marta-sd approves ? It just has changes for the example nemo-run script. Thanks!

athitten avatar May 13 '25 23:05 athitten

@jgerh can you please review/approve a small addition to docs/source/evaluation/evaluation_doc.rst in this PR ? Thanks!

athitten avatar May 14 '25 18:05 athitten

@chtruong814 getting a link check error on docs unrelated to this PR. Can you please help ? Thanks!

athitten avatar May 14 '25 18:05 athitten