NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Remove fp8 model init context because it is handled by MCORE

Open guyueh1 opened this issue 8 months ago • 4 comments

[!IMPORTANT]
The Update branch button must only be pressed in very rare occassions. An outdated branch is never blocking the merge of a PR. Please reach out to the automation team before pressing that button.

What does this PR do ?

Remove wrapping GPT model initialization in TE fp8_model_init context, because MCORE has wrapped the initialization of each layer in proper context already.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

guyueh1 avatar Apr 26 '25 23:04 guyueh1

The llama4 tests failed because this PR needed to merge with main to get a fix for those tests. If those are the only tests that failed, then I'm ok merging this after the PR receives an approval.

chtruong814 avatar May 02 '25 02:05 chtruong814

This PR needs further work to handle two cases: mcore_gpt = True or False. Change this to draft until that's fixed.

guyueh1 avatar May 02 '25 17:05 guyueh1

@timmoon10 can you review?

guyueh1 avatar May 06 '25 18:05 guyueh1

CI is ready, let us know when to merge

ko3n1g avatar May 07 '25 22:05 ko3n1g