NeMo
NeMo copied to clipboard
feat: add max_num_unfinalized_calls to AsyncFinalizerCallback
[!IMPORTANT]
TheUpdate branchbutton must only be pressed in very rare occasions. An outdated branch is never blocking the merge of a PR. Please reach out to the automation team before pressing that button.
What does this PR do ?
Cap the number of inflight async checkpoint(s) saving.
collection: utils
Changelog
- add
max_num_unfinalized_callstoAsyncFinalizerCallback
Usage
AsyncFinalizerCallback()for default behaviorAsyncFinalizerCallback(max_num_unfinalized_calls=5)to set the threshold
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
- [x] Make sure you read and followed Contributor guidelines
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
PR Type:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
- Related to # (issue)