NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Long context performance doc hot fix

Open youngeunkwon0405 opened this issue 1 year ago • 1 comments

What does this PR do ?

Hotfix for table style in long context performance documentation.

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

youngeunkwon0405 avatar Oct 18 '24 16:10 youngeunkwon0405

@erhoo82 Hi Sangkug, I guess Github Markdown system doesn't allow the HTML based table styling. This PR fixes the issue. Could you please review this.

youngeunkwon0405 avatar Oct 18 '24 16:10 youngeunkwon0405

LGTM, thanks

BoxiangW avatar Oct 21 '24 18:10 BoxiangW

Doc only change & 2 approvals : PR good to merge

pablo-garay avatar Oct 21 '24 21:10 pablo-garay