NeMo

NeMo copied to clipboard

Reame
Issues

Add CI Tests for Canary/AEDMultitask "lang_field"

Open tbartley94 opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe.

Some of the Canary changes lead to unreliable use of the lang_field slot. There should be a test to check for it in the future for CI integration.

Describe the solution you'd like

Add a CI test to aed_models that switches out the lang_field and confirms same outputs regardless
Make this CI test take into account cases where target_lang has prompts that are not in the tokenizer.

Aug 09 '24 19:08 tbartley94

I'll look into that.

Aug 21 '24 17:08 pzelasko

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sep 21 '24 01:09 github-actions[bot]

@pzelasko did you fix this? (no pressure, just checking if I should take down)

Sep 21 '24 19:09 tbartley94

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Oct 22 '24 01:10 github-actions[bot]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Nov 22 '24 02:11 github-actions[bot]

@pzelasko were you able to address this?

Nov 26 '24 11:11 tbartley94

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Dec 27 '24 01:12 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

Jan 04 '25 01:01 github-actions[bot]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Feb 21 '25 01:02 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

Feb 28 '25 02:02 github-actions[bot]