NeMo-Guardrails icon indicating copy to clipboard operation
NeMo-Guardrails copied to clipboard

Add the option to disable loading default config

Open aptlin opened this issue 2 years ago • 3 comments

Thanks so much for making this awesome project open-source! Here is a small pet peeve about the current design: at the moment from_content always loads the default instructions, together with the dir-loading branch offrom_path. Since the default config is only relevant for NVIDIA, should we make this behavior opt-in?

aptlin avatar Apr 28 '23 09:04 aptlin

Hi @aptlin! The default config is not meant to be NVIDIA-specific. In the default sample conversation, the question "Tell me a bit about the history of NVIDIA" is meant as an example of a general question. It could have been "Who invented the internet?" or anything else. Did you notice any unintended behaviour because of that?

Currently, without a sample conversation, the LLM will not perform as well in predicting the canonical forms for user and bot messages. That's why there's the option to override it, by specifying your own, or use the default one. But not remove it completely.

drazvan avatar Apr 28 '23 10:04 drazvan

Makes sense, thanks! Not sure if it gets overriden though in the cases I've listed above, because _join_config just appends the instructions.

aptlin avatar Apr 28 '23 10:04 aptlin

Indeed, you are right. It does not get overridden. Will push a fix shortly. Thanks for catching this!

drazvan avatar Apr 28 '23 11:04 drazvan

Should be fixed now. Will be included in the next release. Thanks again!

drazvan avatar Apr 28 '23 19:04 drazvan