Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard

[Dev] Optimize TE cudagraph input memory

Open buptzyb opened this issue 1 month ago • 5 comments

What does this PR do ?

main PR #2392

Reuse TE cudagraph static input tensor memory buffer among microbatches. This doesn't reduce memory when cudagraph is running up. But if you have a large number of microbatches, this reduces the memory used to preprare the static input tensors for cudagraph capturing.

image

:warning: For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]

Pre-checks

  • [ ] I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • [ ] I have added relevant unit tests
  • [ ] I have added relevant functional tests
  • [ ] I have added proper typing to my code Typing guidelines
  • [ ] I have added relevant documentation
  • [ ] I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

buptzyb avatar Nov 25 '25 04:11 buptzyb

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 25 '25 04:11 copy-pr-bot[bot]

/ok to test c04b798921215af6a3b8d17853e4e09dce23c90a

buptzyb avatar Nov 26 '25 01:11 buptzyb

/ok to test c08df6609d7ab236d950deb25e1e22f2f25880d2

buptzyb avatar Nov 26 '25 05:11 buptzyb

This PR introduces significant logic changes but no corresponding unit tests. Please consider add tests for _get_sample_arguments()

yanring avatar Nov 26 '25 07:11 yanring

This PR introduces significant logic changes but no corresponding unit tests. Please consider add tests for _get_sample_arguments()

Added to test_cuda_graphs.py

buptzyb avatar Nov 27 '25 03:11 buptzyb

/ok to test c3a590ff650824fba8ba3944a9194aee7ed25dd2

buptzyb avatar Dec 01 '25 12:12 buptzyb

/ok to test c8ecbb436ea9fe30e6d784506f83d88b26a59b29

buptzyb avatar Dec 01 '25 12:12 buptzyb

/ok to test 3a082d0db1e37b63f1d9a7903d2003685cd85a91

buptzyb avatar Dec 02 '25 11:12 buptzyb