Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard

[MoE] Improvement of shared expert overlap, support shared expert overlap for FlexDispatcher

Open Victarry opened this issue 1 month ago • 4 comments

What does this PR do ?

Design doc: https://docs.google.com/document/d/1whtnUiw1hpfdkjFss_g5P8fyIT9xBA5XJvmdklFes48/edit?usp=sharing Changelog:

  • Add shared expert overlap for FlexDispatcher
  • Add stream wait for cases where CUDA_DEVICE_MAX_CONNECTIONS> 1 to prevent shared expert GEMM launched too early.
  • Change fc1 location of shared experts in A2A dispatcher for better overlap.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]

Pre-checks

  • [ ] I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • [ ] I have added relevant unit tests
  • [ ] I have added relevant functional tests
  • [ ] I have added proper typing to my code Typing guidelines
  • [ ] I have added relevant documentation
  • [ ] I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Victarry avatar Nov 11 '25 09:11 Victarry

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 11 '25 09:11 copy-pr-bot[bot]

@fanshiqing can you please take a look at this MR?

kvareddy avatar Nov 11 '25 09:11 kvareddy

/ok to test 3e308ac

jaredcasper avatar Nov 21 '25 01:11 jaredcasper

@fanshiqing can you please take a look at this MR?

kvareddy avatar Nov 22 '25 08:11 kvareddy

/ok to test 06db4ba0926cf9c554995cac1c99054b625938ef

Victarry avatar Dec 03 '25 03:12 Victarry

/ok to test 7a6d270422cf39a4737ee9412bf6eb747c063609

Victarry avatar Dec 15 '25 09:12 Victarry

/ok to test 3dcb728545045d33082da9b37f8dcbf9544e63ac

Victarry avatar Dec 16 '25 01:12 Victarry