[Dev][Draft] fix(moe): Support HybridEP and reduce memory overhead for 1F1B A2A overlap
What does this PR do ?
- replace
enable_deepepwithuse_flex_dispatcherso that deepep and hybridep will be treated in the same way in 1f1b a2a overlap; - add some deconstructors in 1f1b a2a overlap to release the references to tensors, which helps to reduce the memory overhead;
:warning: For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.
Contribution process
flowchart LR
A[Pre-checks] --> B[PR Tests]
subgraph Code Review/Approval
C1[Expert Review] --> C2[Final Review]
end
B --> C1
C2 --> D[Merge]
Pre-checks
- [ ] I want this PR in a versioned release and have added the appropriate Milestone (e.g.,
Core 0.8) - [ ] I have added relevant unit tests
- [ ] I have added relevant functional tests
- [ ] I have added proper typing to my code Typing guidelines
- [ ] I have added relevant documentation
- [ ] I have run the autoformatter.sh on my PR
Code review
The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.
For MRs into `main` branch
(Step 1): Add PR label Expert Review
(Step 2): Collect the expert reviewers reviews
- Attach the
Expert Reviewlabel when your PR is ready for review. - GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.
:warning: Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
- Add
Final Reviewlabel - GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.
(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either [email protected] or [email protected].
Merging your PR
Any member of core-adlr and core-nemo will be able to merge your PR.
This pull request requires additional validation before any workflows can run on NVIDIA's runners.
Pull request vetters can view their responsibilities here.
Contributors can view more details about this message here.
Thanks for the PR. Please mark the title with [Dev] fix(moe): xxx and label this PR with module:moe and dev.
/ok to test 32fc988
/ok to test 6102cc5
/ok to test d29b634
The UT failed for some reasons. Will reopen the PR after the issue is fixed.
/ok to test e0e6da1
/ok to test 04199ce
/ok to test e9e662b
/ok to test fe05568
/ok to test 776d224
/ok to test 487eea9
@yanring @Victarry Could you give a final review of this PR? We did some modifications after the previous changes.
/ok to test c568c37
@lhb8125 could you fix the api checks? https://github.com/NVIDIA/Megatron-LM/blob/main/docs/api-backwards-compatibility-check.md
/ok to test 36648e3
/ok to test 0708cc1
/ok to test 2cfaec1
/ok to test 0f8663b
/ok to test 97de523
/ok to test 12a2a22