Megatron-LM icon indicating copy to clipboard operation
Megatron-LM copied to clipboard
Published 1 month ago • verified publisher icon NVIDIA

The phrase "need to want to" is grammatically incorrect

Open A-transformer opened this issue 7 months ago • 1 comments

The docstring contains "Set to true if you need to want to compute output logits/loss." The phrase "need to want to" is grammatically incorrect and unclear.

A-transformer avatar May 13 '25 12:05 A-transformer

This is just a typo

A-transformer avatar May 15 '25 05:05 A-transformer

Marking as stale. No activity in 60 days.

github-actions[bot] avatar Jul 14 '25 18:07 github-actions[bot]

rerouted this change to model_provider.py and included in commit e002b5c23c0f8681bbf42df1c3eb07ec27ff5446

maanug-nv avatar Oct 02 '25 18:10 maanug-nv