DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Add experimental support for Python 3.13t

Open szalpal opened this issue 7 months ago • 63 comments

Category:

New feature (non-breaking change which adds functionality)

Description:

This PR adds support for Python 3.13t. It also adds a test that runs two DALI pipelines at the same time within different threads. Depending on Python version, this will be true parallelism or only concurrency.

At the moment, we need to set PYTHON_GIL=0 environment variable to disable GIL. In future we can omit this by adding py::mod_gil_not_used() to DALI's pybind11 module, however it's better to make sure DALI's working in free-threaded fashion first.

Based on similar PR that adds Python 3.13 support: https://github.com/NVIDIA/DALI/pull/5692

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • [ ] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [ ] N/A

Checklist

Documentation

  • [ ] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [ ] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [ ] N/A

REQ IDs: N/A

JIRA TASK: N/A

szalpal avatar Apr 15 '25 14:04 szalpal

CI MESSAGE: [26991807]: BUILD STARTED

dali-automaton avatar Apr 15 '25 14:04 dali-automaton

CI MESSAGE: [26992708]: BUILD STARTED

dali-automaton avatar Apr 15 '25 14:04 dali-automaton

CI MESSAGE: [27039628]: BUILD STARTED

dali-automaton avatar Apr 16 '25 08:04 dali-automaton

CI MESSAGE: [27039628]: BUILD FAILED

dali-automaton avatar Apr 16 '25 10:04 dali-automaton

CI MESSAGE: [27049583]: BUILD STARTED

dali-automaton avatar Apr 16 '25 12:04 dali-automaton

CI MESSAGE: [27049583]: BUILD FAILED

dali-automaton avatar Apr 16 '25 14:04 dali-automaton

CI MESSAGE: [27060443]: BUILD STARTED

dali-automaton avatar Apr 16 '25 16:04 dali-automaton

CI MESSAGE: [27060443]: BUILD FAILED

dali-automaton avatar Apr 16 '25 18:04 dali-automaton

CI MESSAGE: [27073140]: BUILD STARTED

dali-automaton avatar Apr 16 '25 20:04 dali-automaton

CI MESSAGE: [27073140]: BUILD FAILED

dali-automaton avatar Apr 16 '25 22:04 dali-automaton

CI MESSAGE: [27105456]: BUILD STARTED

dali-automaton avatar Apr 17 '25 10:04 dali-automaton

CI MESSAGE: [27105456]: BUILD FAILED

dali-automaton avatar Apr 17 '25 12:04 dali-automaton

CI MESSAGE: [27155718]: BUILD STARTED

dali-automaton avatar Apr 18 '25 09:04 dali-automaton

CI MESSAGE: [27155718]: BUILD FAILED

dali-automaton avatar Apr 18 '25 11:04 dali-automaton

CI MESSAGE: [27159222]: BUILD STARTED

dali-automaton avatar Apr 18 '25 11:04 dali-automaton

CI MESSAGE: [27159222]: BUILD FAILED

dali-automaton avatar Apr 18 '25 12:04 dali-automaton

CI MESSAGE: [27948556]: BUILD STARTED

dali-automaton avatar May 05 '25 11:05 dali-automaton

CI MESSAGE: [27948556]: BUILD FAILED

dali-automaton avatar May 05 '25 11:05 dali-automaton

CI MESSAGE: [27951464]: BUILD STARTED

dali-automaton avatar May 05 '25 12:05 dali-automaton

CI MESSAGE: [27951464]: BUILD PASSED

dali-automaton avatar May 05 '25 15:05 dali-automaton

Does it work? I don't see even 3.13, let along 3.13t, being used in the tests.

mzient avatar May 07 '25 11:05 mzient

CI MESSAGE: [28155725]: BUILD STARTED

dali-automaton avatar May 08 '25 20:05 dali-automaton

CI MESSAGE: [28155725]: BUILD FAILED

dali-automaton avatar May 08 '25 23:05 dali-automaton

CI MESSAGE: [28188506]: BUILD STARTED

dali-automaton avatar May 09 '25 11:05 dali-automaton

CI MESSAGE: [28188506]: BUILD FAILED

dali-automaton avatar May 09 '25 12:05 dali-automaton

CI MESSAGE: [28195678]: BUILD STARTED

dali-automaton avatar May 09 '25 15:05 dali-automaton

CI MESSAGE: [28197582]: BUILD STARTED

dali-automaton avatar May 09 '25 15:05 dali-automaton

CI MESSAGE: [28197780]: BUILD STARTED

dali-automaton avatar May 09 '25 15:05 dali-automaton

CI MESSAGE: [28197780]: BUILD FAILED

dali-automaton avatar May 09 '25 17:05 dali-automaton

CI MESSAGE: [28284986]: BUILD STARTED

dali-automaton avatar May 12 '25 08:05 dali-automaton