DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Fix inverted mmap inside webdataset reader, cleans copy_read_data_

Open JanuszL opened this issue 1 year ago • 3 comments

  • fix the wrong ussage of mmap when the user is not asking for it inside webdataset
  • cleans up usage of copy_read_data_

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • fix the wrong ussage of mmap when the user is not asking for it inside webdataset
  • cleans up usage of copy_read_data_

Additional information:

Affected modules and functionalities:

  • webdataset reader
  • loaders

Key points relevant for the review:

  • logic

Tests:

  • [x] Existing tests apply
    • python/reader tests
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [ ] N/A

Checklist

Documentation

  • [ ] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [x] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [x] N/A

REQ IDs: N/A

JIRA TASK: N/A

JanuszL avatar Oct 18 '24 14:10 JanuszL

!build

JanuszL avatar Oct 18 '24 14:10 JanuszL

CI MESSAGE: [19486724]: BUILD STARTED

dali-automaton avatar Oct 18 '24 14:10 dali-automaton

CI MESSAGE: [19486724]: BUILD PASSED

dali-automaton avatar Oct 19 '24 04:10 dali-automaton

!build

JanuszL avatar Oct 22 '24 18:10 JanuszL

CI MESSAGE: [19618233]: BUILD STARTED

dali-automaton avatar Oct 22 '24 19:10 dali-automaton

CI MESSAGE: [19618233]: BUILD PASSED

dali-automaton avatar Oct 22 '24 23:10 dali-automaton