DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Add an ability to rewind at the end of the video

Open JanuszL opened this issue 1 year ago • 3 comments

  • in some cases after seeking to the last key frame in the video leads to the premature end of decoding as the decoding doesn't start and yet DALI waits for frames. This PR adds a rewind to one before the last (and so on), frame to make sure we can decode the last frames

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • in some cases after seeking to the last key frame in the video leads to the premature end of decoding as the decoding doesn't start and yet DALI waits for frames. This PR adds a rewind to one before the last (and so on), frame to make sure we can decode the last frames
  • related to https://github.com/NVIDIA/DALI/pull/5669

Additional information:

Affected modules and functionalities:

  • video reader

Key points relevant for the review:

  • NA

Tests:

  • [ ] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [x] N/A
    • I don't have a good idea on how to generate such problematic videos

Checklist

Documentation

  • [ ] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [x] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [x] N/A

REQ IDs: N/A

JIRA TASK: N/A

JanuszL avatar Oct 14 '24 11:10 JanuszL

!build

JanuszL avatar Oct 14 '24 11:10 JanuszL

CI MESSAGE: [19327812]: BUILD STARTED

dali-automaton avatar Oct 14 '24 11:10 dali-automaton

CI MESSAGE: [19327812]: BUILD PASSED

dali-automaton avatar Oct 14 '24 20:10 dali-automaton