DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Multiple crops example

Open mzient opened this issue 1 year ago • 8 comments

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Implements a pipeline example requested by a user in #1579

Additional information:

Affected modules and functionalities:

N/A

Key points relevant for the review:

Tests:

  • [ ] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [X] N/A

Checklist

Documentation

  • [ ] Existing documentation applies
  • [X] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [X] Jupyter
    • [ ] Other
  • [ ] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [X] N/A

REQ IDs: N/A

JIRA TASK: N/A

mzient avatar Oct 02 '24 14:10 mzient

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CI MESSAGE: [18958041]: BUILD STARTED

dali-automaton avatar Oct 02 '24 14:10 dali-automaton

CI MESSAGE: [18958465]: BUILD STARTED

dali-automaton avatar Oct 02 '24 14:10 dali-automaton

CI MESSAGE: [18958465]: BUILD PASSED

dali-automaton avatar Oct 02 '24 16:10 dali-automaton

For the future, I belive we could make the resize and crop ops support similar trick, likely in a bit more straightforward way.

stiepan avatar Oct 04 '24 10:10 stiepan

View / edit / reply to this conversation on ReviewNB

szkarpinski commented on 2024-10-04T11:44:12Z ----------------------------------------------------------------

Line #42.        )  # convert to float and mark outermost dimension as"frame"

Nitpicks: Why +0.0 and not cast? Also, there's a missing space before "frame"


View / edit / reply to this conversation on ReviewNB

szkarpinski commented on 2024-10-04T11:44:13Z ----------------------------------------------------------------

How about adding a sentence explaining what the images above mean? The first single image was confusing to me - I expected sequences of equal length. It took me some time to notice num_crops = random (...) in the code.


mzient commented on 2024-11-04T11:46:51Z ----------------------------------------------------------------

Yeah, I'd recommend playing with the seed a bit to get an example with three different sequence lengths, preferably without a single-image sequence.

Yeah, I'd recommend playing with the seed a bit to get an example with three different sequence lengths, preferably without a single-image sequence.


View entire conversation on ReviewNB

mzient avatar Nov 04 '24 11:11 mzient