DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Move old ImageDecoder to legacy module and make the nvImageCodec based ImageDecoder the default

Open jantonguirao opened this issue 10 months ago • 28 comments

Category:

Other Replaces default ImageDecoders with the nvImageCodec based implementations.

Description:

  • Replaces default ImageDecoders with the nvImageCodec based implementations.
  • Move former default decoders to a legacy module

Additional information:

Affected modules and functionalities:

  • ImageDecoder*

Key points relevant for the review:

Tests:

  • [x] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [ ] N/A

Checklist

Documentation

  • [x] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [ ] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [x] N/A

REQ IDs: N/A

JIRA TASK: N/A

jantonguirao avatar Apr 25 '24 16:04 jantonguirao

!build

jantonguirao avatar Apr 25 '24 16:04 jantonguirao

CI MESSAGE: [14518294]: BUILD STARTED

dali-automaton avatar Apr 25 '24 16:04 dali-automaton

CI MESSAGE: [14518294]: BUILD FAILED

dali-automaton avatar Apr 25 '24 16:04 dali-automaton

CI MESSAGE: [14536354]: BUILD STARTED

dali-automaton avatar Apr 26 '24 07:04 dali-automaton

CI MESSAGE: [14538241]: BUILD STARTED

dali-automaton avatar Apr 26 '24 09:04 dali-automaton

CI MESSAGE: [14538241]: BUILD FAILED

dali-automaton avatar Apr 26 '24 09:04 dali-automaton

CI MESSAGE: [14538775]: BUILD STARTED

dali-automaton avatar Apr 26 '24 09:04 dali-automaton

CI MESSAGE: [14539149]: BUILD STARTED

dali-automaton avatar Apr 26 '24 10:04 dali-automaton

CI MESSAGE: [14539370]: BUILD STARTED

dali-automaton avatar Apr 26 '24 10:04 dali-automaton

CI MESSAGE: [14539149]: BUILD FAILED

dali-automaton avatar Apr 26 '24 10:04 dali-automaton

CI MESSAGE: [14539370]: BUILD FAILED

dali-automaton avatar Apr 26 '24 10:04 dali-automaton

CI MESSAGE: [14539920]: BUILD STARTED

dali-automaton avatar Apr 26 '24 11:04 dali-automaton

CI MESSAGE: [14539920]: BUILD FAILED

dali-automaton avatar Apr 26 '24 23:04 dali-automaton

CI MESSAGE: [14598489]: BUILD STARTED

dali-automaton avatar Apr 29 '24 10:04 dali-automaton

CI MESSAGE: [14598565]: BUILD STARTED

dali-automaton avatar Apr 29 '24 10:04 dali-automaton

CI MESSAGE: [14598726]: BUILD STARTED

dali-automaton avatar Apr 29 '24 10:04 dali-automaton

CI MESSAGE: [14598726]: BUILD FAILED

dali-automaton avatar Apr 29 '24 11:04 dali-automaton

CI MESSAGE: [14599974]: BUILD STARTED

dali-automaton avatar Apr 29 '24 12:04 dali-automaton

CI MESSAGE: [14600806]: BUILD STARTED

dali-automaton avatar Apr 29 '24 13:04 dali-automaton

CI MESSAGE: [14601469]: BUILD STARTED

dali-automaton avatar Apr 29 '24 13:04 dali-automaton

CI MESSAGE: [14599974]: BUILD FAILED

dali-automaton avatar Apr 29 '24 13:04 dali-automaton

CI MESSAGE: [14601469]: BUILD FAILED

dali-automaton avatar Apr 29 '24 15:04 dali-automaton

CI MESSAGE: [14604182]: BUILD STARTED

dali-automaton avatar Apr 29 '24 15:04 dali-automaton

CI MESSAGE: [14604182]: BUILD FAILED

dali-automaton avatar Apr 29 '24 15:04 dali-automaton

CI MESSAGE: [14605900]: BUILD STARTED

dali-automaton avatar Apr 29 '24 16:04 dali-automaton

CI MESSAGE: [14605900]: BUILD FAILED

dali-automaton avatar Apr 29 '24 17:04 dali-automaton

CI MESSAGE: [14607591]: BUILD STARTED

dali-automaton avatar Apr 29 '24 17:04 dali-automaton

CI MESSAGE: [14607591]: BUILD PASSED

dali-automaton avatar Apr 29 '24 20:04 dali-automaton

I wonder if it makes sense to add an alias to (already deprecated) fn.image_decoder in fn.legacy.image_decoder. This doesn't improve backward compatibility (if somebody was using fn.image_decoder and wants to stick with the old decoder they can as well type fn.legacy.decoders.image instead of fn.legacy.image_decoder)

szkarpinski avatar May 08 '24 12:05 szkarpinski

CI MESSAGE: [14848065]: BUILD STARTED

dali-automaton avatar May 08 '24 14:05 dali-automaton