DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Add enumeration of supported border modes

Open stiepan opened this issue 2 years ago • 6 comments

Signed-off-by: Kamil Tokarski [email protected]

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Adds enum type with border modes supported by the filter (convolution) operator. The enum must be exposed in Python so that it can be used as a value passed for operator's border_mode argument.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • [ ] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [x] N/A

Checklist

Documentation

  • [ ] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [x] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [x] N/A

REQ IDs: N/A

JIRA TASK: DALI-2949

stiepan avatar Sep 21 '22 09:09 stiepan

!build

stiepan avatar Sep 21 '22 10:09 stiepan

CI MESSAGE: [5969400]: BUILD STARTED

dali-automaton avatar Sep 21 '22 10:09 dali-automaton

CI MESSAGE: [5969400]: BUILD FAILED

dali-automaton avatar Sep 21 '22 10:09 dali-automaton

!build

stiepan avatar Sep 21 '22 10:09 stiepan

CI MESSAGE: [5969480]: BUILD STARTED

dali-automaton avatar Sep 21 '22 10:09 dali-automaton

CI MESSAGE: [5969480]: BUILD PASSED

dali-automaton avatar Sep 21 '22 12:09 dali-automaton

After some discussion I decided to close this one in favour of:

  1. using plain strings in python API (so no enum exposure through pybind),
  2. in the meantime @szalpal added similar enum, sticking to it. https://github.com/NVIDIA/DALI/pull/4284

https://github.com/NVIDIA/DALI/pull/4298

stiepan avatar Sep 29 '22 11:09 stiepan