DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Add bytes_per_sample_hint parameter to parallel external source

Open stiepan opened this issue 2 years ago • 3 comments

Signed-off-by: Kamil Tokarski [email protected]

Category:

New feature (non-breaking change which adds functionality)

Description:

Adds a new parameter to parallel external source to enable user to provide a hint as to the sample size. This way parallel external source can precompute more resonalbe estimation of the required shared memory size and prevent DALI from reallocating the memory during pipeline run. When adjusting shm size, DALI at least doubles the size of a given chunk, so providing more accurate size explicitly can result in less memory consumption.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • [ ] Existing tests apply
  • [x] New tests added
    • [x] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [ ] N/A

Checklist

Documentation

  • [ ] Existing documentation applies
  • [x] Documentation updated
    • [x] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [ ] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [x] N/A

REQ IDs: N/A

JIRA TASK: DALI-2960

stiepan avatar Aug 11 '22 09:08 stiepan

!build

stiepan avatar Aug 16 '22 15:08 stiepan

CI MESSAGE: [5655422]: BUILD STARTED

dali-automaton avatar Aug 16 '22 15:08 dali-automaton

CI MESSAGE: [5655422]: BUILD PASSED

dali-automaton avatar Aug 16 '22 18:08 dali-automaton

!build

stiepan avatar Sep 30 '22 09:09 stiepan

CI MESSAGE: [6054183]: BUILD STARTED

dali-automaton avatar Sep 30 '22 09:09 dali-automaton

CI MESSAGE: [6054183]: BUILD FAILED

dali-automaton avatar Sep 30 '22 10:09 dali-automaton

!build

stiepan avatar Sep 30 '22 13:09 stiepan

CI MESSAGE: [6055571]: BUILD STARTED

dali-automaton avatar Sep 30 '22 13:09 dali-automaton

CI MESSAGE: [6055571]: BUILD PASSED

dali-automaton avatar Sep 30 '22 14:09 dali-automaton

!build

stiepan avatar Dec 06 '22 17:12 stiepan

CI MESSAGE: [6695427]: BUILD STARTED

dali-automaton avatar Dec 06 '22 18:12 dali-automaton

CI MESSAGE: [6695427]: BUILD FAILED

dali-automaton avatar Dec 06 '22 18:12 dali-automaton

!build

stiepan avatar Dec 07 '22 10:12 stiepan

CI MESSAGE: [6703496]: BUILD STARTED

dali-automaton avatar Dec 07 '22 10:12 dali-automaton

CI MESSAGE: [6703496]: BUILD PASSED

dali-automaton avatar Dec 07 '22 13:12 dali-automaton