DALI icon indicating copy to clipboard operation
DALI copied to clipboard

Generate signatures

Open klecki opened this issue 5 years ago • 1 comments

TODO:

  • [ ] deduplicate between modules
  • [ ] See if explicit kwargs break something
  • [ ] Does it help with IDE integration?

Signed-off-by: Krzysztof Lecki [email protected]

Why we need this PR?

Set signatures of DALI calls.

What happened in this PR?

  • What solution was applied: Decorate the __call__ or fn.op and set the signature explicitly. Bind the arguments to signature to group and reorder them as needed by the operator (between named positional args and kwargs).

Reference: https://www.python.org/dev/peps/pep-0362/

  • Affected modules and functionalities: ops and fn Python APIs.
  • Key points relevant for the review: [ Describe here what is the most important part that reviewers should focus on. ]
  • Validation and testing: [ Describe here if and how this PR is tested. ]
  • Documentation (including examples): [ Describe here if documentation and examples were updated. ]

JIRA TASK: [Use DALI-XXXX or NA]

klecki avatar Oct 21 '20 14:10 klecki

CI MESSAGE: [3840113]: BUILD FAILED

dali-automaton avatar Jan 27 '22 16:01 dali-automaton

Done in #5154

klecki avatar Jan 24 '24 10:01 klecki