AMGX icon indicating copy to clipboard operation
AMGX copied to clipboard

DRAFT: Remove runtime type selection

Open mattmartineau opened this issue 2 years ago • 3 comments

Managing runtime selection of the supported types in AmgX makes the code more complex but doesn't seem to benefit users significantly from our discussions so far.

This is a draft pull request that will eventually remove all runtime type selection and instead allow users to choose type at compile time.

mattmartineau avatar Jul 06 '22 08:07 mattmartineau

Yes that's exactly correct - the current version is just hacked but it shows the desired outcome of having only compile time type selection. CMake flags like you suggested will be necessary.

Thanks

mattmartineau avatar Aug 02 '22 08:08 mattmartineau

Do you think having C++ interface would make sense?

marsaev avatar Aug 02 '22 09:08 marsaev

If you mean generally for AmgX then, yes, I definitely do - we have been considering it for a while.

mattmartineau avatar Aug 02 '22 09:08 mattmartineau