RL icon indicating copy to clipboard operation
RL copied to clipboard

Update megatron bridge and megatron-core

Open yaoyu-33 opened this issue 1 month ago • 4 comments

What does this PR do ?

update 3rdparty versions

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • [ ] Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Updated project submodule dependencies to latest compatible versions.

✏️ Tip: You can customize this high-level summary in your review settings.

yaoyu-33 avatar Nov 25 '25 18:11 yaoyu-33

✅ Submodule Fast-Forward Check Results

Check based on commit: d98aae44b2292f516e2d64f387eeee56952a69d4 (PR #1568 from update-3rdparty-mcore)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward) Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

github-actions[bot] avatar Nov 25 '25 18:11 github-actions[bot]

📝 Walkthrough

Walkthrough

Updated two third-party submodule pointers: Megatron-Bridge to commit 1e9a459b43aa1f62ca1356e554d2b0196ebdd546 and Megatron-LM to commit 0d401602bf48046683adfc2542a70613f6e772e6. No functional or behavioral changes.

Changes

Cohort / File(s) Summary
Megatron-Bridge submodule
3rdparty/Megatron-Bridge-workspace/Megatron-Bridge
Updated submodule pointer from 8aa287df3ca6833c78733460f0c0f0bcfb79f5de to 1e9a459b43aa1f62ca1356e554d2b0196ebdd546
Megatron-LM submodule
3rdparty/Megatron-LM-workspace/Megatron-LM
Updated submodule pointer from 76065f17e1e1e2850d1e9009ae5f601007aeeeb3 to 0d401602bf48046683adfc2542a70613f6e772e6

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

mcore

Suggested reviewers

  • yfw

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update megatron bridge and megatron-core' accurately reflects the main changes in the pull request—updating the Megatron-Bridge and Megatron-LM submodule pointers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor submodule pointer updates with no functional changes; test documentation not required for maintenance changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch update-3rdparty-mcore

[!TIP]

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 25 '25 18:11 coderabbitai[bot]

✅ Submodule Fast-Forward Check Results

Check based on commit: 88070484d8c2de0cffe51e6a8fbea815f18bda15 (PR #1568 from update-3rdparty-mcore)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward) Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

github-actions[bot] avatar Nov 25 '25 18:11 github-actions[bot]

Closes https://github.com/NVIDIA-NeMo/RL/issues/1575

yfw avatar Nov 26 '25 22:11 yfw

✅ Submodule Fast-Forward Check Results

Check based on commit: 0dfa1330d5ad3a5ca450a53cc3b1ae6ce2772df4 (PR #1568 from update-3rdparty-mcore)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward) Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

github-actions[bot] avatar Dec 02 '25 21:12 github-actions[bot]

✅ Submodule Fast-Forward Check Results

Check based on commit: 29f86858974ee86e335671b1bcda26a7d73579fa (PR #1568 from update-3rdparty-mcore)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward) Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

github-actions[bot] avatar Dec 03 '25 06:12 github-actions[bot]

✅ Submodule Fast-Forward Check Results

Check based on commit: 1176efc90f90cb2c6aefe82c34bb6bad426a3b7d (PR #1568 from update-3rdparty-mcore)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward) Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

github-actions[bot] avatar Dec 03 '25 07:12 github-actions[bot]