models icon indicating copy to clipboard operation
models copied to clipboard

Save and load SOK model embeddings

Open wenjing-nv opened this issue 3 years ago • 9 comments

Fixes # (issue)

Goals :soccer:

Provide an interfact for SOKEmbedding load/dump and a sample code for SOKEmbedding model load/dump

Implementation Details :construction:

Testing Details :mag:

This ticket is about saving and loading a model trained with SOK. this might take 1 or two releases.

wenjing-nv avatar Jan 17 '23 13:01 wenjing-nv

related PR: https://github.com/NVIDIA-Merlin/models/pull/863

rnyak avatar Jan 18 '23 17:01 rnyak

@WonderingWJ is this the duplicate of https://github.com/NVIDIA-Merlin/models/pull/863? shall we remove this one or keep both, bcs both are required? could you please provide some info? thanks.

rnyak avatar Feb 13 '23 16:02 rnyak

@rnyak This one is not a duplication of https://github.com/NVIDIA-Merlin/models/pull/863. This one targets to solve the load/dump for SOK. That one is to integrate SOK into merlin models

wenjing-nv avatar Feb 16 '23 07:02 wenjing-nv

@WonderingWJ is this still WIP or this is ready? could you update your branch? thanks.

rnyak avatar Feb 22 '23 16:02 rnyak

@WonderingWJ any update on that PR? can we close it?

rnyak avatar Mar 08 '23 17:03 rnyak

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

edknv avatar Mar 21 '23 16:03 edknv

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

The dump/load method of SOK is under development. After SOK load/dump is done, we can discuss this MR. Currently, we don't need to rebase. Thank you!

wenjing-nv avatar Mar 23 '23 13:03 wenjing-nv

@WonderingWJ any update on that PR? can we close it?

Sorry for late response. The SOK load/dump is under development. Currently, we can keep this MR and discuss it after SOK load/dump is done.

wenjing-nv avatar Mar 23 '23 13:03 wenjing-nv