models icon indicating copy to clipboard operation
models copied to clipboard

[Task] Update notebooks to note we require TF 2.8+ in the notebooks.

Open benfred opened this issue 4 years ago • 4 comments

Description

The notebooks currently include code like

import os
os.environ["TF_GPU_ALLOCATOR"]="cuda_malloc_async"
import merlin.models.tf as mm

This causes a segfault in TF 2.6. We should add a note to our notebooks saying that this requires TF 2.8+

benfred avatar Apr 20 '22 17:04 benfred

And instructions commented out for how to deal with this in 2.6 and lower.

EvenOldridge avatar Apr 21 '22 16:04 EvenOldridge

related to https://github.com/NVIDIA-Merlin/Merlin/issues/229

rnyak avatar Apr 25 '22 15:04 rnyak

Based on Benedikt's experiment on testbook unit tests, he could avoid Jenkins error after removing `os.environ["TF_GPU_ALLOCATOR"]="cuda_malloc_async" line.

rnyak avatar Apr 25 '22 15:04 rnyak

@benfred , do we need to track this still?

viswa-nvidia avatar Jul 08 '22 22:07 viswa-nvidia

@viswa-nvidia I closed the ticket, as there is no progress. Please reopen, if we require it.

bschifferer avatar Apr 03 '23 11:04 bschifferer