isaac_ros_common
isaac_ros_common copied to clipboard
run_dev.sh : git lfs print_error never prints
Due to the set -e usage at the top of the script, when the git lfs check is run:
# Check if git-lfs is installed.
git lfs &>/dev/null
if [[ $? -ne 0 ]] ; then
print_error "git-lfs is not insalled. Please make sure git-lfs is installed before you clone the repo."
exit 1
fi
The check is never called because the git lfs command fails and no output is seen. I know git lfs is a prerequisite but it took me a very long time to remember that when setting up a new machine, as I had expected the error to be printed
Just encountered this. Related: https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_common/issues/167